Review Request: iPod handler: various cleanups (3 commits squashed)

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102964/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

iPod handler: raise libgpod dep to 0.7.93 and simplify iTunes db writing

Even Debian stable has libgpod-0.7.93 packaged in main repo, so this
shouldn't hurt and this version is much more convenient to work with.

The change is logged in ChangeLog and README is also adjusted.
--


iPod handler: cleanup slots that are called when worker threads are done

There was a logic error - slot...Succeeded slots were called even when
the thread did not succeed. (because they were connected to the "done"
signals) This is fixed now.

It seems that some actions (writing to debug() etc.) performed upon job
failures were removed, but they were in fact already duplicated in
slot...Succeeded methods.

Stale & orphaned needs much more work, this is just a start.
--


iPod handler: remove unused attributes

these attributes, enums and fwd-declarations aren't used, remove them.
--


Diffs
-----

  CMakeLists.txt 1ffb60e072346b7af368adcfd2ac5e9daa6b4bf9 
  ChangeLog a99a4de75b1941ecdc7cb3b41cce9ad3c996df27 
  README 619bc56f238cbd132f0c5c0647058c17f16d0caa 
  src/core-impl/collections/ipodcollection/CMakeLists.txt 1bf1aa49601d6eedfde741eaf7e232a81a9bd4bb 
  src/core-impl/collections/ipodcollection/handler/IpodHandler.h 24ba45ad507b127d6bbb92ca367afb31f5e86460 
  src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp 041eecf60d79fe0203dfb824186cbe96a9a696a5 

Diff: http://git.reviewboard.kde.org/r/102964/diff/diff


Testing
-------

Everything still works with iPod nano 2G and iPod nano 4G. It would be great if someone with iPod shuffle could test, as a part of code only relevant for shuffles is touched.


Thanks,

Matěj Laitl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111026/1297b910/attachment.html>