Review Request: Add keyboard shortcut for collection search

Silver Juurik silverjuurik at gmail.com
Mon Oct 24 16:31:04 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102956/
-----------------------------------------------------------

(Updated Oct. 24, 2011, 4:31 p.m.)


Review request for Amarok.


Changes
-------

Renamed the methods to slotFocusPlaylistSearch and slotFocusCollectionSearch. The text for the "Jump to" action changed to "Search playlist". Debug blocks removed.


Description
-------

The patch adds a keyboard shortcut for moving focus to collection search input box. The default shortcut is ctrl+F.

The idea is from a JJ: https://bugs.kde.org/show_bug.cgi?id=257381
The keyboard shortcuts ctrl+J (an existing shortcut that moves focus to playlist search box) and ctrl+F partially solve the problem described in the bug.


Diffs (updated)
-----

  src/MainWindow.h 076628f 
  src/MainWindow.cpp 2d2ebac 
  src/browsers/collectionbrowser/CollectionWidget.h a206914 
  src/browsers/collectionbrowser/CollectionWidget.cpp ace058a 

Diff: http://git.reviewboard.kde.org/r/102956/diff/diff


Testing
-------


Thanks,

Silver Juurik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111024/03d21ae5/attachment-0001.html>


More information about the Amarok-devel mailing list