Review Request: Add keyboard shortcut for collection search

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102956/#review7581
-----------------------------------------------------------


Good, thanks for your work, Silver.

I've found an interesting corner case - while the keyboard is always focused to collection search upon CTRL+F, the collection widget itself does not show itself if it was previously hidden - see these screenshots to see when it happens: http://www.laitl.cz/soubory/amarok-ctrl-f-1.jpeg http://www.laitl.cz/soubory/amarok-ctrl-f-2.jpeg

You may perhaps have luck looking at the "Amarok bookmarks" code to see how to raise Collection browser widget - especially the part dealing with amarok://navigate/... urls.

- Matěj Laitl


On Oct. 24, 2011, 4:31 p.m., Silver Juurik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102956/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2011, 4:31 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> The patch adds a keyboard shortcut for moving focus to collection search input box. The default shortcut is ctrl+F.
> 
> The idea is from a JJ: https://bugs.kde.org/show_bug.cgi?id=257381
> The keyboard shortcuts ctrl+J (an existing shortcut that moves focus to playlist search box) and ctrl+F partially solve the problem described in the bug.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h 076628f 
>   src/MainWindow.cpp 2d2ebac 
>   src/browsers/collectionbrowser/CollectionWidget.h a206914 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ace058a 
> 
> Diff: http://git.reviewboard.kde.org/r/102956/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Silver Juurik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111024/9c888c5b/attachment.html>