Review Request: Avoid memory error in MP4TagHelper::embeddedCover() (bug 283675)
Charles Reiss
woggling at gmail.com
Tue Oct 11 16:48:21 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102828/
-----------------------------------------------------------
Review request for Amarok.
Description
-------
Don't access Taglib::MP4::CoverArt objects from an out of scope TagLib::MP4::CoverArtList.
This addresses bug 283675.
https://bugs.kde.org/show_bug.cgi?id=283675
Diffs
-----
shared/tag_helpers/MP4TagHelper.cpp 4226081
Diff: http://git.reviewboard.kde.org/r/102828/diff/diff
Testing
-------
Verified that adding MP4 file with embedded cover art to playlist (that crashed before patch on my OS X setup) did not crash after patching.
Thanks,
Charles Reiss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111011/1ebebf0a/attachment.html>
More information about the Amarok-devel
mailing list