Review Request: Initial look into equalizer scritping. Very experimental.

[Ryan McCoskrie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102798/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

This patch is the beginning of an effort to make a generic equalizer interface for plugins and scripts to access.

0: Gives the EngineController controller class three new functions for examining and choosing the current preset.
0: Started to add equalizer support into the class AmarokEngineScript.
0: Began work to make the EqualizerDialog class a front end on the equalizer facilities in EngineController.

WARNING: Adding custom presets with this patch in place is almost certainly not possible.


Diffs
-----

  src/EngineController.h 3da2f23 
  src/EngineController.cpp 5bea5c6 
  src/dialogs/EqualizerDialog.h 9dad055 
  src/dialogs/EqualizerDialog.cpp ddcd300 
  src/scriptengine/AmarokEngineScript.h f1cdb8c 
  src/scriptengine/AmarokEngineScript.cpp 395c504 

Diff: http://git.reviewboard.kde.org/r/102798/diff/diff


Testing
-------

0: Briefly tested the Amarok.Engine.eqChangeCurrentPreset() function in the script console. Works as expected.
0: Amarok.Engine.eqBandsFreq() seems to return no value.


Thanks,

Ryan McCoskrie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111007/34cf3c81/attachment.html>