Review Request: Aamrok crashes while sending dbus error replies

Andras Mantia amantia at kde.org
Wed Nov 23 09:40:40 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103213/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

Sometimes Amarok just crashes (without playing everything), see http://paste.kde.org/149438/ . The cause is sending a wrong dbus reply message. The patch fixes it, creates and error *reply* message, instead of an error message.


Diffs
-----

  src/dbus/DBusQueryHelper.cpp 59985ce 

Diff: http://git.reviewboard.kde.org/r/103213/diff/diff


Testing
-------


Thanks,

Andras Mantia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111123/3d04cda0/attachment.html>


More information about the Amarok-devel mailing list