Review Request: Warn against build without taglib
Matěj Laitl
matej at laitl.cz
Wed Nov 9 12:18:19 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103090/#review8044
-----------------------------------------------------------
Ship it!
Fine with me. (Anyone knows why taglib does'nt use macro_optional_log_feature?)
- Matěj Laitl
On Nov. 9, 2011, 4:51 a.m., Ryan McCoskrie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103090/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2011, 4:51 a.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> Makes CMake print a stern warning against building Amarok without support of taglib if it is attempted.
>
>
> Diffs
> -----
>
> CMakeLists.txt 6fb0491
>
> Diff: http://git.reviewboard.kde.org/r/103090/diff/diff
>
>
> Testing
> -------
>
> Built Amarok with this patch applied.
>
>
> Thanks,
>
> Ryan McCoskrie
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111109/7538852f/attachment.html>
More information about the Amarok-devel
mailing list