Review Request: Done some improvements on Gpodder Service

Commit Hook null at kde.org
Mon Nov 7 18:30:47 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103034/#review7998
-----------------------------------------------------------


This review has been submitted with commit 19354428df28c59d665f38ad0e8f657f22d17733 by Bart Cerneels to branch master.

- Commit Hook


On Nov. 7, 2011, 12:45 a.m., Lucas Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103034/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2011, 12:45 a.m.)
> 
> 
> Review request for Amarok, Stefan Derkits and Bart Cerneels.
> 
> 
> Description
> -------
> 
> Done some improvements on GPodder Service.
> 
> Fixes:
> * Annoying popup related to KIO (wrapper around QNetworkAccessManager) (Seems that the libmygpo-qt version fixed it)
> * GPodderProvider can be loaded in runtime also.
> * Preserve persistence of GPodderService EpisodeActions during shutdown and restart of Amarok. 
> * Now, we send EpisodeActions in Amarok start or when a user stop/pause and doesn't resume listening in 60 seconds.
> 
> Know bugs:
> * Even though GpodderProvider can be loaded during runtime, the PodcastBrowser is not showing it :/.
> 
> 
> Diffs
> -----
> 
>   src/services/gpodder/GpodderProvider.cpp 15996f8 
>   src/services/gpodder/GpodderService.cpp 9e04d38 
>   src/services/gpodder/GpodderServiceConfig.cpp 5ff6dea 
>   src/services/gpodder/GpodderServiceModel.cpp ef35c2f 
>   src/services/gpodder/GpodderServiceSettings.cpp 51ab598 
> 
> Diff: http://git.reviewboard.kde.org/r/103034/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111107/528aa20b/attachment.html>


More information about the Amarok-devel mailing list