Review Request: Find field names (filter keywords) even if they are translated

[Daniel Faust]

On Nov. 6, 2011, 6:10 p.m., Daniel Faust wrote:
> > Good work, Daniel! Please fix remaining minor fix and I'll be happy to merge this. (or, do you have commit access yourself?)

I can commit myself once everything is fine.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103014/#review7978
-----------------------------------------------------------


On Nov. 6, 2011, 7:29 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103014/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2011, 7:29 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> The filters (eg. filesize, artist) can be translated but without this patch components like the EditFilterDialog won't recognize the keywords.
> 
> I haven't committed it yet because it also changes the keyword 'modifydate' to 'modified' since i think that that's a bug, too.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/support/TextualQueryFilter.cpp 2a44a30 
>   src/core/meta/support/MetaConstants.cpp fabb146 
> 
> Diff: http://git.reviewboard.kde.org/r/103014/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111106/8414c266/attachment.html>