[amarok] /: Add option to toggle showing of browser background images

[Rick W. Chen]

On 06 Nov 2011 09:22 +0100, Bart Cerneels:
> Micro option! And as far as I can tell because only one user
> complained on the forums. Unless Rick has a personal preference.
> Still, we need to be very hesitant to add micro options.
> 
> The arguments for having the backgrounds:
> - Reduces the "field of grey" effect when the browsers are empty.
> - General prettyness
> - Recognition of browser without reading
> 
> Any reasons to have the option to remove them besides: one user wants it?

It is my personal preference. I didn't know about the user in the
forum.

I almost always have the collection browser open. Sometimes the
background makes the texts harder to read. That's why I prefer not to
have them shown. I generally agree with the arguments you gave, but for
me readability is more important.

A note on prettyness: If you have enabled qt tree collapse/expand
animations, during that time the background image would not be visible.
It is filled with base window colour and when the animation stops the
image will suddenly reappear. That's just how it works. You can also see
this in the album applet. Visually that's not too pleasing.

> 
> Bart
> 
> On Sun, Nov 6, 2011 at 05:18, Rick W. Chen <stuffcorpse at archlinux.us> wrote:
> > Git commit 07ca7cc2ea3d792bd7f4b63e8eac68bbd5358f46 by Rick W. Chen.
> > Committed on 05/11/2011 at 14:03.
> > Pushed by rickc into branch 'master'.
> >
> > Add option to toggle showing of browser background images
> >
> > M  +1    -0    ChangeLog
> > M  +4    -0    src/amarokconfig.kcfg
> > M  +8    -0    src/browsers/BrowserCategory.cpp
> > M  +3    -0    src/browsers/BrowserCategory.h
> > M  +3    -2    src/browsers/collectionbrowser/CollectionWidget.cpp
> > M  +3    -2    src/browsers/filebrowser/FileBrowser.cpp
> > M  +2    -2    src/browsers/playlistbrowser/APGCategory.cpp
> > M  +3    -2    src/browsers/playlistbrowser/DynamicCategory.cpp
> > M  +4    -2    src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp
> > M  +3    -2    src/browsers/playlistbrowser/PodcastCategory.cpp
> > M  +11   -4    src/configdialog/dialogs/GeneralConfig.ui
> >
> > http://commits.kde.org/amarok/07ca7cc2ea3d792bd7f4b63e8eac68bbd5358f46

-- 
    Rick