Review Request: Re-Add old "Normal" moodbar style

[Florian Eßer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103036/
-----------------------------------------------------------

(Updated Nov. 4, 2011, 10:37 a.m.)


Review request for Amarok.


Changes
-------

Changed the hardcoded numerical values to enum.
(But they still depend on the item order in the GeneralConfig.ui combo box "kcfg_MoodbarPaintStyle")


Description
-------

This patch re-adds the old pre-2.4.0 moodbar "Normal" style as a fifth option in the moodbar style selection dialog.

Sorry to reheat the old topic from https://bugs.kde.org/show_bug.cgi?id=264432, but upgrading to Kubuntu 11.10 (overwriting my self-compiled Amarok version) made me recognize that this bug is still not fixed.
The old "Normal" style was and is *not* the (IMHO ugly) happy style, so 82d102ba32e0a1b6a154dfe4653e786229c0dcb7 did not really fix the bug. Please have a look at the attached screenshot for a comparison of the different moodbar styles.


This addresses bug 264432.
    https://bugs.kde.org/show_bug.cgi?id=264432


Diffs (updated)
-----

  src/configdialog/dialogs/GeneralConfig.ui 14b2d63 
  src/moodbar/MoodbarManager.h 375e625 
  src/moodbar/MoodbarManager.cpp 53bea15 

Diff: http://git.reviewboard.kde.org/r/103036/diff/diff


Testing
-------

worksforme


Screenshots
-----------

Comparison of different moodbar styles.
  http://git.reviewboard.kde.org/r/103036/s/322/


Thanks,

Florian Eßer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111104/37b40455/attachment.html>