Review Request: Done some improvements on Gpodder Service

Lucas Gomes x8lucas8x at gmail.com
Fri Nov 4 01:27:20 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103034/
-----------------------------------------------------------

(Updated Nov. 4, 2011, 1:27 a.m.)


Review request for Amarok, Stefan Derkits and Bart Cerneels.


Changes
-------

More fixes ^^. Please, let me know if I am missing something or if something should be changed.


Description
-------

Done some improvements on GPodder Service.

Fixes:
* Annoying popup related to KIO (wrapper around QNetworkAccessManager) (Seems that the libmygpo-qt version fixed it)
* GPodderProvider can be loaded in runtime also.
* Preserve persistence of GPodderService EpisodeActions during shutdown and restart of Amarok. 
* Now, we send EpisodeActions in Amarok start or when a user stop/pause and doesn't resume listening in 60 seconds.

Know bugs:
* Even though GpodderProvider can be loaded during runtime, the PodcastBrowser is not showing it :/.


Diffs (updated)
-----

  ChangeLog 0b87f8e 
  src/services/gpodder/GpodderProvider.h 8ddc802 
  src/services/gpodder/GpodderProvider.cpp 15996f8 
  src/services/gpodder/GpodderService.h 02ff539 
  src/services/gpodder/GpodderService.cpp 9e04d38 
  src/services/gpodder/amarok_service_gpodder.desktop 10661b7 

Diff: http://git.reviewboard.kde.org/r/103034/diff/diff


Testing
-------


Thanks,

Lucas Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111104/9210b4a8/attachment-0001.html>


More information about the Amarok-devel mailing list