Review Request: Re-Add old "Normal" moodbar style

[Florian Eßer]

> On Nov. 3, 2011, 9:17 p.m., Rick W. Chen wrote:
> > I'm fine with replacing the Happy one with the old default option.
> > Happy has always seem a bit too happy...

Hmm, than maybe the next person comes running and complains about the regression that his/hers beloved happy style got removed. (This patch does not replace it)
It would be interesting though to get some kind of usage statistics about how many people are actually using moodbar and which profiles they are using...


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103036/#review7921
-----------------------------------------------------------


On Nov. 3, 2011, 10:28 a.m., Florian Eßer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103036/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2011, 10:28 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch re-adds the old pre-2.4.0 moodbar "Normal" style as a fourth option in the moodbar style selection dialog.
> 
> Sorry to reheat the old topic from https://bugs.kde.org/show_bug.cgi?id=264432, but upgrading to Kubuntu 11.10 (overwriting my self-compiled Amarok version) made me recognize that this bug is still not fixed.
> The old "Normal" style was and is *not* the (IMHO ugly) happy style, so 82d102ba32e0a1b6a154dfe4653e786229c0dcb7 did not really fix the bug. Please have a look at the attached screenshot for a comparison of the different moodbar styles.
> 
> 
> This addresses bug 264432.
>     https://bugs.kde.org/show_bug.cgi?id=264432
> 
> 
> Diffs
> -----
> 
>   src/configdialog/dialogs/GeneralConfig.ui 14b2d63 
>   src/moodbar/MoodbarManager.cpp 53bea15 
> 
> Diff: http://git.reviewboard.kde.org/r/103036/diff/diff
> 
> 
> Testing
> -------
> 
> worksforme
> 
> 
> Screenshots
> -----------
> 
> Comparison of different moodbar styles.
>   http://git.reviewboard.kde.org/r/103036/s/322/
> 
> 
> Thanks,
> 
> Florian Eßer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111103/8c2f14a7/attachment-0001.html>