Review Request: Change misleading/ambiguous message when deleting tracks from collection (bug 263693)

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103026/#review7895
-----------------------------------------------------------

Ship it!


Ship It!

- Bart Cerneels


On Nov. 2, 2011, 1:06 p.m., Gilles Habran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103026/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2011, 1:06 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Fix for bug https://bugs.kde.org/show_bug.cgi?id=263693
> 
> The confirmation message to remove tracks from a collection is not misleading/ambiguous anymore (please see explanations in the first post).
> 
> 
> This addresses bug 263693.
>     https://bugs.kde.org/show_bug.cgi?id=263693
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp 349464c 
> 
> Diff: http://git.reviewboard.kde.org/r/103026/diff/diff
> 
> 
> Testing
> -------
> 
> Select some tracks from collection (iPod Nano).
> Right click on selection then Delete Tracks.
> Check if warning message is correct.
> 
> 
> Screenshots
> -----------
> 
> amarok_bug_263693
>   http://git.reviewboard.kde.org/r/103026/s/321/
> 
> 
> Thanks,
> 
> Gilles Habran
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111103/622aa217/attachment.html>