Review Request: Add new collection filter to find exact matches

[Daniel Faust]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102252/
-----------------------------------------------------------

(Updated Nov. 1, 2011, 3:02 p.m.)


Review request for Amarok.


Changes
-------

-Changed the syntax to 'field:=value'
-Added the gui integration


Description
-------

Since I use labels quite intensive it sometimes comes handy to search for songs with an exact label, not just a label containing the string I'm searching for.
So I added a new filter type for this and used the '=' sign.

Searching for label=pop finds songs labeled with 'pop' but not with 'electro pop'.
While searching for label:pop finds songs labeled with 'pop' and 'electro pop'.

This is not integrated into the GUI like the EditFilterDialog since I wanted to hear your opinions first.


Diffs (updated)
-----

  src/core-impl/collections/support/Expression.h 1e49f45 
  src/core-impl/collections/support/Expression.cpp 531850a 
  src/core-impl/collections/support/TextualQueryFilter.cpp 735772b 
  src/dialogs/EditFilterDialog.cpp 91628ff 
  src/widgets/MetaQueryWidget.h 3db49d3 
  src/widgets/MetaQueryWidget.cpp 5db1ded 

Diff: http://git.reviewboard.kde.org/r/102252/diff/diff


Testing
-------

I'm using this patch for a few weeks now without any problems.


Screenshots
-----------


  http://git.reviewboard.kde.org/r/102252/s/221/


Thanks,

Daniel Faust

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111101/d299d1a2/attachment.html>