Review Request: Add autoscroll function to the lyrics applet.

Ralf Engels ralf-engels at gmx.de
Tue May 24 21:12:20 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101155/#review3491
-----------------------------------------------------------

Ship it!


Diff looks fine,
Will submit it unless I see a Veto.

- Ralf


On April 21, 2011, 7:58 a.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101155/
> -----------------------------------------------------------
> 
> (Updated April 21, 2011, 7:58 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> The text of the current song is automatically scrolled according to the position in the song. If the scrollbar is pressed and moved the autoscroll is disabled till the scollbar is released and it can be disabled/reactivated manually by clicking on an action. Whether autoscrolling is enabled or disabled is saved over Amarok restarts.
> 
> 
> Diffs
> -----
> 
>   src/context/applets/lyrics/LyricsApplet.h 17c91bf 
>   src/context/applets/lyrics/LyricsApplet.cpp a9c6be3 
> 
> Diff: http://git.reviewboard.kde.org/r/101155/diff
> 
> 
> Testing
> -------
> 
> Tested and worked fine.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110524/cb529c14/attachment.htm 


More information about the Amarok-devel mailing list