Review Request: Fix Inconsistencies with Organize Files Dialog when canceling Dialog

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100321/#review3331
-----------------------------------------------------------


This request has been lying around unchanged for quite some time.

The patch doesn't look that bad but what about the discussions? 
Nobody seemed to miss an "Add preset" button till now, so why add one?

Can you summarize the latest state, update the patch and tell me if I should apply it?

- Ralf


On Jan. 8, 2011, 12:12 p.m., Philipp Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100321/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2011, 12:12 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Fixes two errors:
> 
> First: Presets are being saved explicitely, meaning they should persist even when the Dialog is aborted/canceled.
> Second: The state of the Current Collection Directory is saved regardless of whether the Dialog was accepted or canceled. IMO it should only be saved like all other values when it is accepted.
> 
> 
> Diffs
> -----
> 
>   ChangeLog 3c337d1 
>   src/dialogs/OrganizeCollectionDialog.cpp b7d7850 
> 
> Diff: http://git.reviewboard.kde.org/r/100321/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Philipp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110515/ed67e907/attachment.htm