Review Request: Fix for USB storage mode media players

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100194/#review3329
-----------------------------------------------------------

Ship it!


Apart from the small thing with the drive == 0 everything seems to be quite good.
I would ship it with the additional check.

- Ralf


On Dec. 8, 2010, 9:55 p.m., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100194/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2010, 9:55 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This patch fixes identifying general USB storage mode media players, plus adds some minor fixes and cleanups. The main change is in UmsConnectionAssistant::identify method.
> 
> 
> Diffs
> -----
> 
>   src/MediaDeviceCache.cpp babb8ff 
>   src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp 92339ff 
>   src/core-impl/collections/umscollection/support/UmsConnectionAssistant.cpp 5956a2b 
> 
> Diff: http://git.reviewboard.kde.org/r/100194/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Amarok in USB mode
>   http://git.reviewboard.kde.org/r/100194/s/21/
> 
> 
> Thanks,
> 
> Lukáš
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110515/cad6c180/attachment.htm