Review Request: Fix some audio cd related issue: not playing, skipping tracks with gstreamer, no length shown

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100647/#review3325
-----------------------------------------------------------

Ship it!


Couldn't see any obvious problems with the patch and I can only support a patch that finally fixes some audio cd issues.

I say ship it.

- Ralf


On Feb. 13, 2011, 5:42 p.m., Arnold Metselaar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100647/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2011, 5:42 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Don't start a new track in the EngineController if the new title is the one we just started. (fixes bug 222405) 
> Handle a device specifier (?device=<deviceName>) in EngineController::playUrl, the old code would not play if the deviceName had a slash (/) in it. (fixes bug 261175).
> Use KIO:NetAccess::stat to compute track lengths, previously shown as 0:00, fixes bug 207806.
> src/core-impl/meta/cdda/AudioCdTrackProvider_p.cpp (AudioCdTrackProvider::Private::Private,AudioCdTrackProvider::Private::deviceAdded): Fix some typos, that may have caused crashes.
> 
> 
> This addresses bugs 207806, 222405 and 261175.
>     https://bugs.kde.org/show_bug.cgi?id=207806
>     https://bugs.kde.org/show_bug.cgi?id=222405
>     https://bugs.kde.org/show_bug.cgi?id=261175
> 
> 
> Diffs
> -----
> 
>   src/EngineController.h 4117a89 
>   src/EngineController.cpp 31928a7 
>   src/core-impl/collections/audiocd/AudioCdCollection.h a3baf61 
>   src/core-impl/collections/audiocd/AudioCdCollection.cpp ef7fabe 
>   src/core-impl/meta/cdda/AudioCdTrackProvider_p.cpp 048e6b6 
> 
> Diff: http://git.reviewboard.kde.org/r/100647/diff
> 
> 
> Testing
> -------
> 
> I have built Debian packages from the changed files and the amarok sources in Debian testing on a computer running Debian stable (Squeeze).
> Playing audio cd's with amarok works, also when I have two audio cd's inserted.
> Detection of audio cd's is still erratic and gstreamer backend seems to re-read the table of contents causing seeking and gaps in the playback.
> 
> 
> Thanks,
> 
> Arnold
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110514/774f4dd4/attachment.htm