Review Request: Amarok cannot detect non-partitioned device

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101329/#review3314
-----------------------------------------------------------

Ship it!


The patch looks sensible and harmless.
Ship It

- Ralf


On May 10, 2011, 4:18 a.m., Matthieu Pupat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101329/
> -----------------------------------------------------------
> 
> (Updated May 10, 2011, 4:18 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Fixes an issue where not partionned device will not show up in Amarok as for those devices from a solid-hardware point of view the StorageDrive and the
> StorageVolume are the same device.
> 
> 
> This addresses bug 272401.
>     https://bugs.kde.org/show_bug.cgi?id=272401
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/umscollection/support/UmsConnectionAssistant.cpp 5956a2b 
> 
> Diff: http://git.reviewboard.kde.org/r/101329/diff
> 
> 
> Testing
> -------
> 
> Tested against 2.4.0.90 as I was unable to build the git repository.
> 
> 
> Thanks,
> 
> Matthieu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110514/71b2d109/attachment.htm