Review Request: Use KImageCache if possible, rather than KPixmapCache

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101347/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

KPixmapCache is horribly buggy, and that is unlikely to ever change.  Its replacement, KImageCache, is much better, but is only available with kdelibs 4.5 and later.  So we use KImageCache if we are building against kdelibs 4.5 or later.

To simplify this, I've created a header-only all-inline class PixmapCache which is a practically-zero-cost wrapper around either KPixmapCache or KImageCache.


Diffs
-----

  CMakeLists.txt 8b4134f 
  ChangeLog b278ef3 
  config-amarok.h.cmake bcf9c8b 
  src/App.cpp 1f01536 
  src/MainWindow.cpp 5c14e89 
  src/PixmapCache.h PRE-CREATION 
  src/SvgHandler.h 7425cde 
  src/SvgHandler.cpp 765eda0 
  src/moodbar/MoodbarManager.h e3f32b5 
  src/moodbar/MoodbarManager.cpp acde9e2 
  src/widgets/BookmarkPopup.cpp 1f62537 

Diff: http://git.reviewboard.kde.org/r/101347/diff


Testing
-------

Works with latest kdelibs.  Haven't checked build against kdelibs 4.4.x.

This fixes at least one crash that I could reproduce reliably.


Thanks,

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110512/3d29c8f5/attachment.htm