Review Request: Make the DAAP protocol parsing in Amarok more robust

[Ruurd Pels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100710/#review3217
-----------------------------------------------------------

Ship it!


Looks good to me.

- Ruurd


On Feb. 21, 2011, 9:23 p.m., Lukas Sandström wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100710/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2011, 9:23 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> The Firefly version installed on my Readynas Duo (Radiator 4.1.7) sends the
> aeMK (mediakind) field as an 32 bit int instead of a 8 bit char.
> 
> Amarok currently only consumes one byte instead of four, despite the fact that
> the field length is correctly reported as four bytes by the server. The
> attached patch reworks the DAAP protocol parsing to be more robust.
> 
> 
> This addresses bug 266676.
>     https://bugs.kde.org/show_bug.cgi?id=266676
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/daap/daapreader/Reader.h 8f882b8 
>   src/core-impl/collections/daap/daapreader/Reader.cpp 744c6a2 
> 
> Diff: http://git.reviewboard.kde.org/r/100710/diff
> 
> 
> Testing
> -------
> 
> Yes. With the attached patch Amarok plays music via DAAP from my NAS just fine.
> 
> 
> Thanks,
> 
> Lukas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110509/c9a847c6/attachment.htm