Review Request: Podcast episode filename configuration

[Bart Cerneels]

> On March 21, 2011, 6:35 a.m., Bart Cerneels wrote:
> > The patch you uploaded doesn't apply, at least that is what reviewboard complains about. For easy review please fix it.

You need to diff against master instead of just the diff of your last commit. So I couldn't even review the raw patch.


- Bart


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100686/#review2075
-----------------------------------------------------------


On March 20, 2011, 6:42 p.m., Sandeep Raghuraman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100686/
> -----------------------------------------------------------
> 
> (Updated March 20, 2011, 6:42 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Summary
> -------
> 
> Adds a dialog to configure podcast episode filenames. Added a filenamelayout column to podcastchannels table and a member to PodcastMeta to hold the filename layout. Podcast database version updated to 5.
> 
> 
> This addresses bug 155075.
>     https://bugs.kde.org/show_bug.cgi?id=155075
> 
> 
> Diffs
> -----
> 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp PRE-CREATION 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 777825e 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 9784d08 
> 
> Diff: http://git.reviewboard.kde.org/r/100686/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandeep
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110321/86afc8de/attachment.htm