Review Request: Podcast episode filename configuration

Sandeep Raghuraman sandy.8925 at gmail.com
Sun Mar 20 19:42:36 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100686/
-----------------------------------------------------------

(Updated March 20, 2011, 6:42 p.m.)


Review request for Amarok and Bart Cerneels.


Changes
-------

Checked for NULL pointers in SqlPodcastProvider::downloadResult(). Also replaced %default by %default% for the sake of consistency as suggested by Sergey.


Summary
-------

Adds a dialog to configure podcast episode filenames. Added a filenamelayout column to podcastchannels table and a member to PodcastMeta to hold the filename layout. Podcast database version updated to 5.


This addresses bug 155075.
    https://bugs.kde.org/show_bug.cgi?id=155075


Diffs (updated)
-----

  src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp PRE-CREATION 
  src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 777825e 
  src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 9784d08 

Diff: http://git.reviewboard.kde.org/r/100686/diff


Testing
-------


Thanks,

Sandeep

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110320/bbf9b271/attachment.htm 


More information about the Amarok-devel mailing list