Review Request: Fix multiple issues with the lyrics applet/engine

[Martin Blumenstingl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100892/
-----------------------------------------------------------

(Updated March 20, 2011, 3:52 p.m.)


Review request for Amarok and Rick W. Chen.


Changes
-------

Make this patch work with latest git master.


Summary (updated)
-------

This fixes the following lyrics related issues:
-Amarok crashed when the lyrics applet was removed and re-added while a track was playing and the user pressed "ESC".
-If no lyrics script was running cached lyrics were not displayed (but an error message that no scripts are running instead - might be a regression).
-If the user edited the lyrics in TagDialog the changes were not "synchronized" to the lyrics applet (this is probably a regression).

Can we make sure this patch gets into the next release?


Diffs (updated)
-----

  src/context/applets/lyrics/LyricsApplet.cpp a2bd27c 
  src/context/engines/lyrics/LyricsEngine.cpp 66a2126 

Diff: http://git.reviewboard.kde.org/r/100892/diff


Testing (updated)
-------

-HTML lyrics are working again
-Amarok does not crash anymore when re-adding the lyrics applet and pressing "ESC"
-If lyrics are edited in TagDialog the LyricsApplet is updated again
etc.


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110320/cca79f66/attachment.htm