Review Request: Organize Collection Wizard

Sergey Ivanov 123kash at gmail.com
Sun Mar 13 23:19:32 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100852/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

Merged Source and Destination dialogs to 1 single wizard. No more separate dialogs for Transcoding and AudioCD source settings.


Diffs
-----

  src/CMakeLists.txt ccd7737 
  src/browsers/CollectionTreeView.h baefe25 
  src/browsers/CollectionTreeView.cpp 5c6afc5 
  src/browsers/filebrowser/FileView.h 1eed9e4 
  src/browsers/filebrowser/FileView.cpp e8fc8af 
  src/core-impl/collections/audiocd/AudioCdCollectionLocation.h 082d0e5 
  src/core-impl/collections/audiocd/AudioCdCollectionLocation.cpp 64664ec 
  src/core-impl/collections/audiocd/CMakeLists.txt 26f9538 
  src/core-impl/collections/audiocd/FormatSelectionPage.h PRE-CREATION 
  src/core-impl/collections/audiocd/FormatSelectionPage.cpp PRE-CREATION 
  src/core-impl/collections/audiocd/FormatSelectionPage.ui PRE-CREATION 
  src/core-impl/collections/db/sql/SqlCollection.cpp 6230067 
  src/core-impl/collections/db/sql/SqlCollectionLocation.h bafdad1 
  src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 5d05770 
  src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.h f5d5a2f 
  src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp 0a902a2 
  src/core-impl/collections/support/TrashCollectionLocation.h a9c9249 
  src/core-impl/collections/support/TrashCollectionLocation.cpp 26859c5 
  src/core/collections/CollectionLocation.h bb56de3 
  src/core/collections/CollectionLocation.cpp 4fb4fa5 
  src/core/transcoding/formats/TranscodingNullFormat.cpp 98f09d1 
  src/dialogs/FilenameLayoutDialog.cpp 94983d3 
  src/dialogs/OrganizeCollectionDialog.h c4f7e6f 
  src/dialogs/OrganizeCollectionDialog.cpp 34da71b 
  src/dialogs/OrganizeCollectionDialogBase.ui 8cf1b5b 
  src/dialogs/OrganizeCollectionPages/CopyMethodPage.h PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/CopyMethodPage.cpp PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/CopyMethodPage.ui PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/DestinationPage.h PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/DestinationPage.cpp PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/DestinationPage.ui PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/DestinationPreviewDialog.h PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/DestinationPreviewDialog.cpp PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/OtherSettingsPage.h PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/OtherSettingsPage.cpp PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/OtherSettingsPage.ui PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/PresetsEditorBase.ui PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/PresetsEditorDialog.h PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/PresetsEditorDialog.cpp PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/TranscodingSettingsPage.h PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/TranscodingSettingsPage.cpp PRE-CREATION 
  src/dialogs/OrganizeCollectionPages/TranscodingSettingsPage.ui PRE-CREATION 
  src/dialogs/OrganizeCollectionWizard.h PRE-CREATION 
  src/dialogs/OrganizeCollectionWizard.cpp PRE-CREATION 
  src/dialogs/TrackOrganizer.h 2595962 
  src/dialogs/TrackOrganizer.cpp b73a7fc 
  src/services/magnatune/MagnatuneCollectionLocation.h d759001 
  src/services/magnatune/MagnatuneCollectionLocation.cpp 8292af2 
  src/transcoding/CMakeLists.txt 06d5be8 
  src/transcoding/TranscodingAssistantDialog.h 718c01d 
  src/transcoding/TranscodingAssistantDialog.cpp b64e74b 
  src/transcoding/TranscodingAssistantDialog.ui 912a1c2 
  src/transcoding/TranscodingOptionsStackedWidget.h 9495d44 

Diff: http://git.reviewboard.kde.org/r/100852/diff


Testing
-------

AudioCD -> SqlCollectio
File -> SqlCollectio
SqlCollection -> iPod
iPod -> SqlCollection
Magnatune -> SqlCollection


Thanks,

Sergey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110313/de472ad9/attachment.htm 


More information about the Amarok-devel mailing list