Review Request: Adds new Track Progression mode which only plays queued items

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100405/#review1911
-----------------------------------------------------------

Ship it!


Feature seems useful and code looks good.

- Sergey


On Jan. 17, 2011, 3:49 a.m., Armin Straub wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100405/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2011, 3:49 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This patch adds a new Track Progression mode which works like "Normal" except that it doesn't keep playing items from the playlist; instead it plays the queued items and then stops.
> 
> Motivation:
> Most of the time I start playing a track (and maybe queue a few more) but immediately choose "Stop playing after current track". With the mode added in this patch, this last step becomes unnecessary.
> 
> Issues:
> As an icon (see screenshot) for this mode, I have just reused the icon for the "Normal" mode. Maybe something like the icon for "Edit Queue" would be more appropriate. (This is in: src/playlist/navigators/NavigatorConfigAction.cpp)
> 
> 
> Diffs
> -----
> 
>   src/amarokconfig.kcfg b1672f3 
>   src/dbus/mpris2/Mpris2DBusHandler.cpp 2bb4dd3 
>   src/playlist/PlaylistActions.cpp ee40bed 
>   src/playlist/navigators/NavigatorConfigAction.h e40dd1c 
>   src/playlist/navigators/NavigatorConfigAction.cpp d665fa8 
>   src/playlist/navigators/StandardTrackNavigator.h 8e1d9ea 
>   src/playlist/navigators/StandardTrackNavigator.cpp 429b915 
> 
> Diff: http://git.reviewboard.kde.org/r/100405/diff
> 
> 
> Testing
> -------
> 
> Works for me...
> 
> 
> Screenshots
> -----------
> 
> Track Progression Modes
>   http://git.reviewboard.kde.org/r/100405/s/47/
> 
> 
> Thanks,
> 
> Armin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110311/4a23e119/attachment.htm