Review Request: Podcast episode filename configuration

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100686/#review1910
-----------------------------------------------------------



src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp
<http://git.reviewboard.kde.org/r/100686/#comment1602>

    setSizePolicy( QSizePolicy::MinimumExpanding, QSizePolicy::Fixed );
    Looks shorter and do the same.



src/core-impl/podcasts/sql/SqlPodcastMeta.cpp
<http://git.reviewboard.kde.org/r/100686/#comment1601>

    It's better to use common token syntax for all kind of tokens (%token%) to keep consistency. So "%default" should be changed on "%default%".



src/core-impl/podcasts/sql/SqlPodcastProvider.cpp
<http://git.reviewboard.kde.org/r/100686/#comment1599>

    This line can bring a crash in case of track without artist.



src/core-impl/podcasts/sql/SqlPodcastProvider.cpp
<http://git.reviewboard.kde.org/r/100686/#comment1600>

    One more crash on track without album.
    Checks are needed for all fields those can be absent.


- Sergey


On March 6, 2011, 7:23 p.m., Sandeep Raghuraman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100686/
> -----------------------------------------------------------
> 
> (Updated March 6, 2011, 7:23 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Summary
> -------
> 
> Adds a dialog to configure podcast episode filenames. Added a filenamelayout column to podcastchannels table and a member to PodcastMeta to hold the filename layout. Podcast database version updated to 5.
> 
> 
> This addresses bug 155075.
>     https://bugs.kde.org/show_bug.cgi?id=155075
> 
> 
> Diffs
> -----
> 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.h PRE-CREATION 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp PRE-CREATION 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigWidget.ui PRE-CREATION 
>   src/core-impl/podcasts/sql/PodcastSettingsDialog.cpp de53d77 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 5bda713 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 777825e 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 9784d08 
>   src/core/podcasts/PodcastMeta.h e11b2eb 
>   src/core/podcasts/PodcastMeta.cpp fb82fa8 
> 
> Diff: http://git.reviewboard.kde.org/r/100686/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandeep
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110311/08fcf741/attachment-0001.htm