Review Request: Filter Editor Dialog "restyling"

Stefan Derkits stefan at derkits.at
Sun Mar 6 12:53:07 CET 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On 01/15/2011 09:35 PM, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100250/#review917
> -----------------------------------------------------------
> 
> 
> Still works, and mentioned bug still open. Any corrections/suggestions/comments? :)
> 
> - Sergey

the Dialog still has a big Bug:

If I choose the Artist Token and enter e.g. Faith No More it creates:
"artist:Faith No More" ... which does mean artist should be/contain
Faith and Filter (I think without Restriction) for No AND More
If you close the Widget and reopen it, you also see that it's no longer
just an Artist Filter but now it is "Artist Name AND Simple Text AND
Simple Text"

I think the pretty simple Solution to this is to put the Text that is
entered for a Token under Quotes ... so that it says artist:"Faith No More"

Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk1zdaIACgkQlZvAMV/NgGK17wCfWxD3TgzBCyFR9rOGFdF2CzRV
XUsAn1q3Lb8oXac0KGdyozY6DepYlSES
=rYSZ
-----END PGP SIGNATURE-----


More information about the Amarok-devel mailing list