Review Request: Podcast episode filename configuration

[Sandeep Raghuraman]

> On Feb. 21, 2011, 7:14 a.m., Bart Cerneels wrote:
> > Dialog needs to be improved and the available tokens (%bla) need to be explained with an info text.
> > File renaming implemented.
> > Removing filename layout from the base class PodcastChannel, it's SQL specific.
> > Code formatting for readability.

I've implemented all changes except for the dialog appearance. I'm just not able to get the dialog to display properly. Any tips on how to use QSizePolicy so that I can get the dialog to display properly?


- Sandeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100686/#review1544
-----------------------------------------------------------


On Feb. 19, 2011, 5:36 p.m., Sandeep Raghuraman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100686/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2011, 5:36 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Summary
> -------
> 
> Adds a dialog to configure podcast episode filenames. Added a filenamelayout column to podcastchannels table and a member to PodcastMeta to hold the filename layout. Podcast database version updated to 5.
> 
> 
> This addresses bug 155075.
>     https://bugs.kde.org/show_bug.cgi?id=155075
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt d47daf4 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.h PRE-CREATION 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigDialog.cpp PRE-CREATION 
>   src/core-impl/podcasts/sql/PodcastFilenameLayoutConfigWidget.ui PRE-CREATION 
>   src/core-impl/podcasts/sql/PodcastSettingsBase.ui e1f36e7 
>   src/core-impl/podcasts/sql/PodcastSettingsDialog.h 08fdad3 
>   src/core-impl/podcasts/sql/PodcastSettingsDialog.cpp de53d77 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 777825e 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 9784d08 
>   src/core/podcasts/PodcastMeta.h e11b2eb 
>   src/core/podcasts/PodcastMeta.cpp fb82fa8 
> 
> Diff: http://git.reviewboard.kde.org/r/100686/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandeep
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110305/c6305529/attachment.htm