Review Request: tag reading support for mod, s3m, it and xm files

[Mathias Stephan Panzenböck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101598/
-----------------------------------------------------------

(Updated June 26, 2011, 10:21 p.m.)


Review request for Amarok.


Changes
-------

I changed the patch so it does not depend on my experimental taglib-mod extension library (which had issues) but instead just checks if taglib supports module file formats (which it will in 1.8.0).


Summary (updated)
-------

This patch adds read/write tag support for mod, s3m, it and xm files if taglib supports it. All new parts are #ifdefed so it won't break if an old taglib version is used.

I wrote a patch for taglib that enables support for these file formats and it will be included in taglib 1.8.0. Here is the pull request:
https://github.com/taglib/taglib/pull/4


This addresses bug 90524.
    https://bugs.kde.org/show_bug.cgi?id=90524


Diffs (updated)
-----

  CMakeLists.txt 0c2e958 
  config-amarok.h.cmake 2d25cc7 
  shared/FileType.h 5c8081f 
  shared/FileType.cpp a6e25d5 
  shared/tag_helpers/TagHelper.cpp 96f763e 

Diff: http://git.reviewboard.kde.org/r/101598/diff


Testing
-------


Thanks,

Mathias Stephan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110626/03f364a3/attachment.htm