Review Request: Fix finalization of track copy process to media device collections (#238912)

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101652/#review3959
-----------------------------------------------------------

Ship it!


Seems to work. Managed to copy successfully to an iPod and the progress bar finished as expected.
Do you want me to commit this in your name or do you have a developer account @ identity.kde.org?

Bart

- Bart


On June 17, 2011, 10:05 a.m., Tommaso Falchi Delitala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101652/
> -----------------------------------------------------------
> 
> (Updated June 17, 2011, 10:05 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Fix bug #238912: copy process to media devices (MTP & Ipod) hangs at the last track and it's never finalized properly, making other further transfers impossible. This problem should affect all device classes flagged as "m_copyingthreadsafe". 
> 
> Inspection of the source code revealed a slot MediaDeviceHandler::slotCopyTrackJobsDone() which is supposed to take care of copy finalization, but it is never used. 
> 
> The patch gets rid of the unused slot MediaDeviceHandler::slotCopyTrackJobsDone() and incorporates into MediaDeviceHandler::enqueueNextCopyThread() the proper steps for the copy process to be finalized correctly, in case no tracks are left to be transferred.
> 
> 
> This addresses bug 238912.
>     https://bugs.kde.org/show_bug.cgi?id=238912
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h 10491cc 
>   src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp 885a2e0 
> 
> Diff: http://git.reviewboard.kde.org/r/101652/diff
> 
> 
> Testing
> -------
> 
> The patched code compiles correctly and the transfer of one or multiple tracks to MTP media devices is correctly finalized.
> 
> 
> Thanks,
> 
> Tommaso
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110617/a7afd928/attachment.htm