Review Request: New context applet, displays all albums in a cover grid view

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100841/#review3719
-----------------------------------------------------------


Okay, so far so good. We're getting there ;)

Two other remarks that prevent your patch from being applied.
* Please fix the look of your applet when you have albums with no cover set, there's still some gray bg showing up, it seems. Looks a bit 
* I'd recommend disabling the horizontal scrollbar completely and fill up the space that's actually there.

Other than that, looks fine.

- Kevin


On June 5, 2011, 3:55 p.m., Manu Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100841/
> -----------------------------------------------------------
> 
> (Updated June 5, 2011, 3:55 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Added a new context applet, called CoverGrid.
> It displays all albums of the collection by their cover art in a grid view.
> Tooltips display album & artist names, mouse double click appends album to playlist
> 
> 
> Diffs
> -----
> 
>   src/context/applets/CMakeLists.txt 25b3f0b 
>   src/context/applets/covergrid/AlbumItem.h PRE-CREATION 
>   src/context/applets/covergrid/AlbumItem.cpp PRE-CREATION 
>   src/context/applets/covergrid/CMakeLists.txt PRE-CREATION 
>   src/context/applets/covergrid/CoverGridApplet.h PRE-CREATION 
>   src/context/applets/covergrid/CoverGridApplet.cpp PRE-CREATION 
>   src/context/applets/covergrid/amarok-context-applet-covergrid.desktop PRE-CREATION 
>   src/context/applets/covergrid/covergridSettings.ui PRE-CREATION 
>   src/context/applets/covergrid/defaultcover.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100841/diff
> 
> 
> Testing
> -------
> 
> basic functionalities seem to work
> 
> 
> Screenshots
> -----------
> 
> new applet in action
>   http://git.reviewboard.kde.org/r/100841/s/96/
> 
> 
> Thanks,
> 
> Manu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110606/2682b0f6/attachment.htm