Review Request: New context applet, displays all albums in a cover grid view

[Manu Wagner]

> On June 5, 2011, 9:38 a.m., Kevin Funk wrote:
> > I'd really like to merge your patch but there are still some issues:
> > * Please have a look at this: http://krf.kollide.net/files/images/amarok-applet-covergrid-issues.png
> >   It looks a bit out of place with less albums, or albums without cover
> > * Use single click to add albums to the playlist
> > * Doesn't compile with current Git, """#include "playlist/PlaylistController.h"""" missing in AlbumItem.cpp and CoverGridApplet.cpp
> > 
> > Please re-submit, thank your very much for the fast responses so far.

hi,

I'll fix the compilation issue right away.
However, as for the out of place issue, I don't really know how to fix it, apart from assigning an automatic cover size, which is currently handled through a setting.
And about the single click vs double, I tend to prefer double-click which seems more natural to me. I'm actually thinking about non intentional single clicks...
And I think single click should be used to other actions in the future, like for instance some kind of "cover flip" to unveil the tracks list (like on the iphone). 


- Manu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100841/#review3678
-----------------------------------------------------------


On June 4, 2011, 4:58 p.m., Manu Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100841/
> -----------------------------------------------------------
> 
> (Updated June 4, 2011, 4:58 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Added a new context applet, called CoverGrid.
> It displays all albums of the collection by their cover art in a grid view.
> Tooltips display album & artist names, mouse double click appends album to playlist
> 
> 
> Diffs
> -----
> 
>   src/context/applets/CMakeLists.txt 25b3f0b 
>   src/context/applets/covergrid/AlbumItem.h PRE-CREATION 
>   src/context/applets/covergrid/AlbumItem.cpp PRE-CREATION 
>   src/context/applets/covergrid/CMakeLists.txt PRE-CREATION 
>   src/context/applets/covergrid/CoverGridApplet.h PRE-CREATION 
>   src/context/applets/covergrid/CoverGridApplet.cpp PRE-CREATION 
>   src/context/applets/covergrid/amarok-context-applet-covergrid.desktop PRE-CREATION 
>   src/context/applets/covergrid/covergridSettings.ui PRE-CREATION 
>   src/context/applets/covergrid/defaultcover.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100841/diff
> 
> 
> Testing
> -------
> 
> basic functionalities seem to work
> 
> 
> Screenshots
> -----------
> 
> new applet in action
>   http://git.reviewboard.kde.org/r/100841/s/96/
> 
> 
> Thanks,
> 
> Manu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110605/0616e94f/attachment-0001.htm