Review Request: Do not show the OSD if a fullscreen application is active

[Kevin Funk]

> On June 5, 2011, 4:47 a.m., Bart Cerneels wrote:
> > I think this is a nice feature. I've been starting to QtCreator full screen and yesterday indeed disabled track notifications in order to focus better.
> > Guess my question is: should this also affect the notifications?
> 
> Kevin Funk wrote:
>     Yep, Martin, please also apply this to the KNotificationBackend. It should be straight forward. 
>     
>     I'm basically the maintainer of the Notification modules, it would be a good idea to use a common base (proxy) for all notification backends to simplify features like this. (Didn't have time to do it, yet)
> 
> Martin Blumenstingl wrote:
>     Thanks for the positive feedback :)
>     
>     Bart: I'm not sure if it should also affect the notifications.
>     Shouldn't the KDE notification system take care of that?
>     My kopete notifications for example don't show up if I have mplayer in fullscreen (OK, there's a flickering bug, but in theory it should work: https://bugs.kde.org/show_bug.cgi?id=247656 ).
>     
>     Kevin: sure, putting the code in the KNotificationBackend class seems nice.
>     The OSD could use it then.
>     The question is though: where should I put the CheckBox in the UI, as the OSD settings should not affect the "system notifications"?
>     I could move it under "Use system notifications" but leave it left-aligned, so it's on the same level as "Use On-Screen-Display" and "Use system notifications".

Depends on what you do with KNotify. If you're going to block KNotify from sending out notifications explicitely, keep it left-aligned.
Else just put it in the OSD settings group.

I'd do the latter if KNotify already has that feature.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101508/#review3676
-----------------------------------------------------------


On June 4, 2011, 8:36 p.m., Martin Blumenstingl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101508/
> -----------------------------------------------------------
> 
> (Updated June 4, 2011, 8:36 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> It can be quite annoying if fullscreen applications are running and you are controlling amarok via keyboard shortcuts.
> Then the OSD disturbs you.
> 
> To work around this I simply added a little check which does not show the OSD if a fullscreen application is focused/active.
> Of course this is configurable.
> 
> The behavior does not change with this patch, as the setting defaults to "false".
> 
> 
> Diffs
> -----
> 
>   src/amarokconfig.kcfg 6957e93 
>   src/configdialog/dialogs/NotificationsConfig.cpp 52a0584 
>   src/configdialog/dialogs/NotificationsConfig.ui 3b0c47f 
>   src/widgets/Osd.h fa0755f 
>   src/widgets/Osd.cpp c6b1d22 
> 
> Diff: http://git.reviewboard.kde.org/r/101508/diff
> 
> 
> Testing
> -------
> 
> Tested it with the checkbox enabled and disabled.
> Works as expected.
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110605/54e85c73/attachment.htm