Review Request: Fix lyrics autorefresh in some cases.

Modestas Vainius modestas at vainius.eu
Thu Jul 28 15:38:48 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102110/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

There were some issues mostly when playing streams. Lyrics would stuck with empty text and wouldn't autorefresh until the track was changed or manually refreshed. That's because cachedLyrics() is always empty for streams. Therefore it makes sense to additionally check if either artist or track title have changed as well.


Diffs
-----

  src/context/engines/lyrics/LyricsEngine.cpp 2abeb6d 

Diff: http://git.reviewboard.kde.org/r/102110/diff


Testing
-------


Thanks,

Modestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110728/36101fea/attachment.htm 


More information about the Amarok-devel mailing list