Review Request: Prevent last.fm credential popup on Amarok start if none are set

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102079/#review5108
-----------------------------------------------------------


This review has been submitted with commit 22b369ddfe14cb7109eb39d08c6f9786dea9b578 by Sam Lade to branch master.

- Commit


On July 24, 2011, 9:36 p.m., Sam Lade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102079/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 9:36 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> As of commit 202c49ebf8b5521b0394b4b7c5e816bf4057c8de, if the Last.FM plugin is enabled, but no username and password are set, a request for the username and password is popped up on Amarok start.
> This is because this commit calls polish() on each service as it is created. If the service hasn't set m_inited = true when this happens (which is the case when no last.fm username and password are set), a dialogue pops up asking for them.
> 
> This simply removes that call. It was never run in older versions of Amarok, since apparently polish() was never called.
> 
> There may be better ways of doing it, but if so I can't work them out. Everything seems to work properly this way.
> 
> 
> Diffs
> -----
> 
>   src/services/lastfm/LastFmService.cpp ce0b6ec09f3403c44cb26eece994637d2db5db15 
> 
> Diff: http://git.reviewboard.kde.org/r/102079/diff
> 
> 
> Testing
> -------
> 
> Amarok started with and without last.fm credentials set. Everything seems to behave as expected. No badgering popups are shown.
> 
> 
> Thanks,
> 
> Sam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110725/f49f61cc/attachment-0001.htm