Review Request: Partial Rewrite of ID3v2TagHelper.cpp

Stefan Derkits stefan at derkits.at
Sat Jul 23 01:33:52 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102055/
-----------------------------------------------------------

(Updated July 22, 2011, 11:33 p.m.)


Review request for Amarok and Ralf Engels.


Changes
-------

fixed some bugs introduced by this patch


Summary
-------

Rewrite if else else if Constructs to switch statements

Add common Frame Names to m_fieldMap


Diffs (updated)
-----

  shared/tag_helpers/ID3v2TagHelper.cpp 27e0cf0a9f6dc0bfbbd54cab65cb65dd6bef8a33 

Diff: http://git.reviewboard.kde.org/r/102055/diff


Testing (updated)
-------

compared output of collectionscanner before & after patch -> fixed some, but still some slight problems with TrackNo


Thanks,

Stefan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110722/bc5f2be3/attachment.htm 


More information about the Amarok-devel mailing list