Review Request: Prevent FavoredRandomTrackNavigator choosing files chosen very recently (fix bug 244442)

[Brendon Higgins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101836/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

Prevent FavoredRandomTrackNavigator choosing files chosen in recent past (fix bug 244442). Heavily based on the way RandomTrackNavigator already does it - i.e. generate recent history, and disqualifying those tracks from being chosen (in this case, by assigning 0 weight). Indeed, parts are copied from RandomTrackNavigator. This version of the patch applies to current HEAD (as opposed to the patch I posted on the bug report).

Myriam Schweingruber asked that I post it here. I claim that it /should/ work as advertised - the approach is already working in RandomTrackNavigator - but I've done no testing (I'm lucky to have found the time to do even /this/ much).


This addresses bug 244442.
    https://bugs.kde.org/show_bug.cgi?id=244442


Diffs
-----

  src/playlist/navigators/FavoredRandomTrackNavigator.h dafe48f 
  src/playlist/navigators/FavoredRandomTrackNavigator.cpp 44b8499 

Diff: http://git.reviewboard.kde.org/r/101836/diff


Testing
-------


Thanks,

Brendon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110702/9e9fda5c/attachment.htm