Review Request: Implements a preview button in the collection organizer dialog along with an "automatic preview" checkbox

[Maximilian Güntner]

> On Jan. 24, 2011, 10:12 a.m., Mark Kretschmann wrote:
> > Ok, this patch looks good to me, I'm in favor of pushing it to Git Master. Maximilian, do you have push access to KDE Git? If not, we can push it for you.
> > 
> > PS:
> > Looking at this screenshot, I can't help noticing that the GUI has serious issues (not the changes that this patch introduced, but generally). What's it with the ugly bold borders around those buttons at the top? We should really clean that up...
> >

I don't have push access. Please push it for me, thanks!

We should open a bug report/feature request for the GUI so that somebody can clean it up an make it more intuitive. 
In my opinion, a wizard would be a better solution when it comes to moving a whole collection. 
But a compact window like this is a better approach when you just want to copy some files to your DAP.


- Maximilian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100270/#review1046
-----------------------------------------------------------


On Jan. 20, 2011, 11 p.m., Maximilian Güntner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100270/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2011, 11 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This patch adds manual preview functionality to the collection organizer dialog. This is very handy when altering the filename scheme and options of large collections ( > 1k files) since the dialog doesn't update the preview widget with every change in the filename configurator. The current functionality can be achieved by clicking on "Automatic Preview". Hope you like it.
> 
> 
> Diffs
> -----
> 
>   src/dialogs/OrganizeCollectionDialog.cpp a104c8e 
>   src/dialogs/OrganizeCollectionDialogBase.ui 2f28102 
> 
> Diff: http://git.reviewboard.kde.org/r/100270/diff
> 
> 
> Testing
> -------
> 
> -tested auto update by using/clicking each element that connects to the signalmapper
> -tested the manual preview button
> -moved a collection
> 
> 
> Screenshots
> -----------
> 
> Preview Button and auto preview checkbox
>   http://git.reviewboard.kde.org/r/100270/s/31/
> 
> 
> Thanks,
> 
> Maximilian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110124/4e84fbaa/attachment.htm