Review Request: Prevent crash in "Similar Artists" applet when nothing playing
Tuomas Nurmi
tuomas at norsumanageri.org
Sun Jan 16 00:28:35 CET 2011
> On Jan. 15, 2011, 7:58 p.m., Sergey Ivanov wrote:
> > Make sense. Ship it.
No commit access here, so someone else has to perform the magic...
- Tuomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100385/#review912
-----------------------------------------------------------
On Jan. 14, 2011, 3:23 p.m., Tuomas Nurmi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100385/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2011, 3:23 p.m.)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> A simple fix for "similar artists" applet crash as reported on the bug.
>
>
> This addresses bug 263145.
> https://bugs.kde.org/show_bug.cgi?id=263145
>
>
> Diffs
> -----
>
> src/context/applets/similarartists/SimilarArtistsApplet.cpp b1b340f
>
> Diff: http://git.reviewboard.kde.org/r/100385/diff
>
>
> Testing
> -------
>
> Before: Crashes when clicking "Show similar artists for currently playing track" with nothing playing.
> After: Does not.
>
>
> Thanks,
>
> Tuomas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110115/971eeec8/attachment.html
More information about the Amarok-devel
mailing list