Review Request: Change tooltips for time labels according to leftTimeDisplayRemaining setting

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100371/#review913
-----------------------------------------------------------



src/widgets/ProgressWidget.cpp
<http://git.reviewboard.kde.org/r/100371/#comment772>

    This duplicated call can be deleted also.



src/widgets/ProgressWidget.cpp
<http://git.reviewboard.kde.org/r/100371/#comment773>

    Better to make new function public and move this call here, to prevent setting toolTip text every second. Less overhead.
    http://gitweb.kde.org/amarok.git/blob/HEAD:/src/widgets/TimeLabel.h#l47


- Sergey


On Jan. 12, 2011, 3:52 p.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100371/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2011, 3:52 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> The tooltip for the left time label used to be "The amount of time elapsed in current song" always. But since the time labels can be swapped by user, the tooltips should swap accordingly.
> 
> 
> Diffs
> -----
> 
>   src/widgets/ProgressWidget.h 939c0aa 
>   src/widgets/ProgressWidget.cpp f7a75c1 
> 
> Diff: http://git.reviewboard.kde.org/r/100371/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110115/9e208558/attachment-0001.htm