Review Request: Patch for resolving Inconsistent display of track numbering in Collection browser and Playlist. JJ Bug No. 260973

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100394/#review910
-----------------------------------------------------------

Ship it!


Looks ok.

- Sergey


On Jan. 15, 2011, 3:52 p.m., Bhargav Mangipudi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100394/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2011, 3:52 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> According to JJ Bug No. 260973, there is an inconsistency in the track numbering in collection browser and playlist. Playlist has "%1 - " + Song Name while collection browser has "%1. " + Song Name.
> 
> This patch makes both displays consistent to "%1 - " format. 
> 
> 
> This addresses bug https://bugs.kde.org/260973.
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/260973
> 
> 
> Diffs
> -----
> 
>   src/browsers/CollectionTreeItemModelBase.cpp 7e76866 
> 
> Diff: http://git.reviewboard.kde.org/r/100394/diff
> 
> 
> Testing
> -------
> 
> I have tested this patch.
> 
> 
> Thanks,
> 
> Bhargav
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110115/f4d23cb4/attachment.htm