Review Request: Do not create default APG presets based on filename

Soren Harward stharward at gmail.com
Thu Jan 13 00:16:44 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100372/#review860
-----------------------------------------------------------

Ship it!


Looks good.

- Soren


On Jan. 12, 2011, 5:39 p.m., Edward Hades Toroshchin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100372/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2011, 5:39 p.m.)
> 
> 
> Review request for Amarok and Soren Harward.
> 
> 
> Summary
> -------
> 
> Currently APG creates default example presets if it fails to load a file that contains "playlistgenerator.xml" in the name. That's not nice.
> 
> 
> Diffs
> -----
> 
>   src/playlistgenerator/PresetModel.h d526378 
>   src/playlistgenerator/PresetModel.cpp eb02bcb 
> 
> Diff: http://git.reviewboard.kde.org/r/100372/diff
> 
> 
> Testing
> -------
> 
> It compiles, it creates example presets if playlistgenerator.xml is missing.
> 
> 
> Thanks,
> 
> Edward Hades
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110112/3d4b45ee/attachment-0001.htm 


More information about the Amarok-devel mailing list