Review Request: mysql embedded default options

[Ian Monroe]

> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote:
> > The current way we do it is because if you have a MySQL that randomly doesn't support whatever argument you are trying to use, Bad Things Happen. If you look at the history of this code it is quite turbulent. 
> > 
> > Surely there is a place that is writable that we could use instead?
> > 
> > Granted your solution only uses one argument so its probably fine. But in general it would be better to find a solution that doesn't alter the logic here.

Well rereading your description I see this is because it "doesn't reliably" find the config file. I guess that sounds like the mysql embedded that I know. 

Still seems like a step backward to use the arguments again though... the whole reason we use a config file in the first place is to avoid using arguments.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100345/#review829
-----------------------------------------------------------


On Jan. 10, 2011, 11:44 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100345/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2011, 11:44 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> The mysql embedded library doesn't reliably find the config file on Windows, instead it tries to write into the write-protected install location. This patch uses the mysql API instead of setenv and should work on all platforms. It shouldn't change the current behaviour, when you test please still backup your .kde/share/apps/amarok/mysqle database directory before trying.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp 4e8088d 
> 
> Diff: http://git.reviewboard.kde.org/r/100345/diff
> 
> 
> Testing
> -------
> 
> on Microsoft Visual Studio 2010 EE (msvc2010) it works as expected.
> 
> 
> Thanks,
> 
> Patrick
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110111/07b5dc8a/attachment.htm