Review Request: mysql embedded default options

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100345/#review825
-----------------------------------------------------------


Have not yet tested, will do later. In general it sounds like a great idea to me, especially if it also works on Linux and OSX.

- Mark


On Jan. 10, 2011, 11:44 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100345/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2011, 11:44 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> The mysql embedded library doesn't reliably find the config file on Windows, instead it tries to write into the write-protected install location. This patch uses the mysql API instead of setenv and should work on all platforms. It shouldn't change the current behaviour, when you test please still backup your .kde/share/apps/amarok/mysqle database directory before trying.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp 4e8088d 
> 
> Diff: http://git.reviewboard.kde.org/r/100345/diff
> 
> 
> Testing
> -------
> 
> on Microsoft Visual Studio 2010 EE (msvc2010) it works as expected.
> 
> 
> Thanks,
> 
> Patrick
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110110/c957f47e/attachment.htm