Short review of two commits

[Philipp Schmidt]

On Sonntag 09 Januar 2011 13:39:57 Myriam Schweingruber wrote:
>So unfortunately we Kubuntu users can't test, sorry.

I am using arch with KDE 4.5.5 coompiled packages and I too get the following error using both xine 0.2.60 and vlc 0.3.1 backends with current git:

amarok: BEGIN: void Playlist::Controller::clear() 
amarok:   BEGIN: void Playlist::Controller::removeRows(int, int) 
amarok:     BEGIN: void Playlist::Controller::removeRows(QList<int>&) 
amarok:       BEGIN: virtual void Playlist::RemoveTracksCmd::redo() 
amarok:         BEGIN: void Playlist::Model::removeTracksCommand(const Playlist::RemoveCmdList&) 
amarok:           BEGIN: void Playlist::PrettyListView::slotPlaylistActiveTrackChanged() 
amarok:             BEGIN: void Playlist::PrettyListView::scrollToActiveTrack() 
amarok:             END__: void Playlist::PrettyListView::scrollToActiveTrack() [Took: 0s] 
amarok:           END__: void Playlist::PrettyListView::slotPlaylistActiveTrackChanged() [Took: 0s] 
amarok:           BEGIN: void StatusBar::updateTotalPlaylistLength() 
amarok:           END__: void StatusBar::updateTotalPlaylistLength() [Took: 0s] 
amarok:         END__: void Playlist::Model::removeTracksCommand(const Playlist::RemoveCmdList&) [Took: 0.001s] 
amarok:       END__: virtual void Playlist::RemoveTracksCmd::redo() [Took: 0.001s] 
amarok:     END__: void Playlist::Controller::removeRows(QList<int>&) [Took: 0.001s] 
amarok:   END__: void Playlist::Controller::removeRows(int, int) [Took: 0.001s] 
amarok: END__: void Playlist::Controller::clear() [Took: 0.012s] 
amarok: BEGIN: void Playlist::ProgressiveSearchWidget::slotFilterClear() 
amarok: END__: void Playlist::ProgressiveSearchWidget::slotFilterClear() [Took: 0s] 
QWidget::setMinimumSize: (Playlist dock/Playlist::Dock) Negative sizes (273,-1) are not possible
amarok: BEGIN: virtual bool Meta::AudioCdAlbum::isCompilation() const 
amarok: END__: virtual bool Meta::AudioCdAlbum::isCompilation() const [Took: 0s] 
amarok: BEGIN: virtual bool Meta::AudioCdAlbum::isCompilation() const 
amarok: END__: virtual bool Meta::AudioCdAlbum::isCompilation() const [Took: 0s] 
amarok: BEGIN: virtual bool Meta::AudioCdAlbum::isCompilation() const 
amarok: END__: virtual bool Meta::AudioCdAlbum::isCompilation() const [Took: 0s] 

and so on...

The thing is however: It also does not work with the 2.3.2 packages from the repository. So perhaps not only a Kubuntu-bug?

Regards
Philipp