[Amarok] 137de44 Fix major issue with the Collection missing whole

Mark Kretschmann kretschmann at kde.org
Sat Jan 8 19:11:02 CET 2011


commit 137de448c030cbfeb9de3bc21969f259a7291eca
branch master
Author: Mark Kretschmann <kretschmann at kde.org>
Date:   Sat Jan 8 19:08:55 2011 +0100

    Fix major issue with the Collection missing whole albums, and mixing up artists.
    
    Big thanks to Ralf Engels, who came up with this fix! :)
    
    BUG: 262459
    CCMAIL: amarok-devel at kde.org

diff --git a/src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp b/src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
index d861da8..4a2b1ab 100644
--- a/src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
+++ b/src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp
@@ -161,6 +161,7 @@ SqlScanResultProcessor::commitTrack( CollectionScanner::Track *track,
     if( m_foundTracks.contains( uid ) )
     {
         warning() << "track"<<track->path()<<"with uid"<<uid<<"already committed. There seems to be a duplicate uid.";
+        return;
     }
     m_foundTracks.insert( uid );
 


More information about the Amarok-devel mailing list