Review Request: Fix Inconsistencies with Organize Files Dialog when canceling Dialog

[Philipp Schmidt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100321/
-----------------------------------------------------------

(Updated Jan. 8, 2011, 12:12 p.m.)


Review request for Amarok.


Changes
-------

Bugreference removed as it was incorrect.


Summary
-------

Fixes two errors:

First: Presets are being saved explicitely, meaning they should persist even when the Dialog is aborted/canceled.
Second: The state of the Current Collection Directory is saved regardless of whether the Dialog was accepted or canceled. IMO it should only be saved like all other values when it is accepted.


Diffs
-----

  ChangeLog 3c337d1 
  src/dialogs/OrganizeCollectionDialog.cpp b7d7850 

Diff: http://git.reviewboard.kde.org/r/100321/diff


Testing
-------


Thanks,

Philipp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110108/bba40b3c/attachment.htm