Review Request: Fix Inconsistencies with Organize Files Dialog when canceling Dialog

Philipp Schmidt philschmidt at gmx.net
Sat Jan 8 12:11:43 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100321/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

Fixes two errors:

First: Presets are being saved explicitely, meaning they should persist even when the Dialog is aborted/canceled.
Second: The state of the Current Collection Directory is saved regardless of whether the Dialog was accepted or canceled. IMO it should only be saved like all other values when it is accepted.


This addresses bug 255325.
    https://bugs.kde.org/show_bug.cgi?id=255325


Diffs
-----

  ChangeLog 3c337d1 
  src/dialogs/OrganizeCollectionDialog.cpp b7d7850 

Diff: http://git.reviewboard.kde.org/r/100321/diff


Testing
-------


Thanks,

Philipp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110108/bc19a92b/attachment.htm 


More information about the Amarok-devel mailing list